PHOENIX-7304 - Adding utilitiy method to get view index ids for given view index table #2026
+153
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajjasani
reviewed
Nov 14, 2024
| throws IOException, SQLException { | ||
| Preconditions.checkArgument(MetaDataUtil.isViewIndex(tableName)); | ||
| List<String> viewIndexIdsString = new ArrayList<>(); | ||
| PreparedStatement preparedStatement = connection.prepareStatement(getViewIndexIdsQuery(tableName, includeTenantViewIndexes)); |
There was a problem hiding this comment.
Good to have INFO log with the value of getViewIndexIdsQuery() to help debug if something goes wrong.
tkhurana
reviewed
Nov 28, 2024
Comment on lines
+493
to
+495
| final String tableName = schemaPrefix + generateUniqueName(); | ||
| final String globalViewName1 = schemaPrefix + generateUniqueName(); | ||
| final String globalViewName2 = schemaPrefix + generateUniqueName(); |
There was a problem hiding this comment.
SchemaUtil#getTableName API is generally used. It works with null schema name.
tkhurana
reviewed
Nov 28, 2024
| /** | ||
| * Retrieves the list of unique view index ids from SYSTEM.CATALOG for a given view index table | ||
| * @param connection - Phoenix Connection | ||
| * @param tableName - name of the view index table for which view index ids need to be retrieved |
There was a problem hiding this comment.
It looks like this is the physical name of the view Index table and not the logical name. Can you update the API document to clarify this.
tkhurana
reviewed
Nov 28, 2024
| } | ||
|
|
||
| // Get view indexes ids only for global view indexes (excluding tenant view indexes) | ||
| List<String> list = ViewUtil.getViewIndexIds(conn.unwrap(PhoenixConnection.class), "_IDX_" + tableName, false); |
There was a problem hiding this comment.
use MetatadataUtil.getViewIndexPhysicalName instead of using hardcoded constants _IDX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding utilitiy method to get view index ids for given view index table
JIRA - PHOENIX-7304