Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-7237 Pherf unit tests PherfTest and ResourceTest are failing #1835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddupg
Copy link
Member

@ddupg ddupg commented Feb 26, 2024

No description provided.

Change-Id: Ia75ad7e305e91c6b8190321948abc8a5883249fc
@stoty
Copy link
Contributor

stoty commented Feb 28, 2024

I don't like this, as this is very brittle, and we will have the same problem again soon. (The previous patch has the same problem)

The real problem is that pherf seems to try to load its test config from anywhere on the classpath.

I would prefer that the logic in getResourcesPath is fixed so that it does not recursively search the whole classpath.

url = ResourceList.class.getResource(resource);

@ddupg
Copy link
Member Author

ddupg commented Feb 28, 2024

I don't like this, as this is very brittle, and we will have the same problem again soon. (The previous patch has the same problem)

The real problem is that pherf seems to try to load its test config from anywhere on the classpath.

I would prefer that the logic in getResourcesPath is fixed so that it does not recursively search the whole classpath.

url = ResourceList.class.getResource(resource);

Thanks @stoty for reviewing and opinion, I'll try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants