PHOENIX-6955 The value of region metric--lastMajorCompactionAge is wrong，when the hfile is buckload file #1606
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong，when the hfile is buckload file
gjacoby126
requested changes
May 18, 2023
| @@ -265,7 +265,8 @@ private WriterLength getNewWriter(final String tableName , byte[] family, Config | |||
| .withBytesPerCheckSum(CompatUtil.getBytesPerChecksum(conf)) | |||
| .withBlockSize(blockSize) | |||
| .withDataBlockEncoding(encoding) | |||
| .withCellComparator(CellComparatorImpl.COMPARATOR); | |||
| .withCellComparator(CellComparatorImpl.COMPARATOR) | |||
| .withCreateTime(System.currentTimeMillis());; | |||
There was a problem hiding this comment.
This should probably be EnvironmentEdgeManager.currentTime() so that tests can override the timestamp correctly.
|
I'm so sorry,I'll do it quickly,thanks for your help
---- Replied Message ----
| From | Geoffrey ***@***.***> |
| Date | 05/19/2023 03:57 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [apache/phoenix] PHOENIX-6955 The value of region metric--lastMajorCompactionAge is wrong，when the hfile is buckload file (PR #1606) |
@gjacoby126 requested changes on this pull request.
Thanks for the patch. Could we also please have a simple test to confirm that the bug's fixed?
In phoenix-core/src/main/java/org/apache/phoenix/mapreduce/MultiHfileOutputFormat.java:
@@ -265,7 +265,8 @@ private WriterLength getNewWriter(final String tableName , byte[] family, Config
.withBytesPerCheckSum(CompatUtil.getBytesPerChecksum(conf))
.withBlockSize(blockSize)
.withDataBlockEncoding(encoding)
- .withCellComparator(CellComparatorImpl.COMPARATOR);
+ .withCellComparator(CellComparatorImpl.COMPARATOR)
+ .withCreateTime(System.currentTimeMillis());;
This should probably be EnvironmentEdgeManager.currentTime() so that tests can override the timestamp correctly.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.