Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDFBOX-3812] Support auto size font for multiline PDTextField #78

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

dannymcpherson
Copy link

@dannymcpherson dannymcpherson changed the title Support auto size font for multiline PDTextField [PDFBOX-3812] Support auto size font for multiline PDTextField Dec 20, 2019
@PascalSchumacher
Copy link

As far as I know the pdfbox maintainers do not monitor github pull request.

I would advice you to add a comment with a link to this pull request to the issue (or send an email to the pdfbox developer mailing list).

@dannymcpherson
Copy link
Author

Thanks for the tip, @PascalSchumacher. I just emailed their dev mailing list.

@msahyoun
Copy link

@dannymcpherson thank you very much for the contribution. @PascalSchumacher is correct that we don't monitor on a regular basis as this is only a mirror and the issues are being tracked using JIRA. Nevertheless I'll be hopefully able to add the changes later today.

There are some possible enhancements I see

  • text can also scale up in order to fit the content area
  • a font increment by 1 might be a little large - maybe there could be a setter for the increment step

asfgit pushed a commit that referenced this pull request Dec 23, 2019
…ields as suggested by dannymcpherson in #78

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/2.0@1871927 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Dec 23, 2019
…ields as suggested by dannymcpherson in #78

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1871928 13f79535-47bb-0310-9956-ffa450edef68
@dannymcpherson
Copy link
Author

Thank you, @msahyoun. I'm working on some changes to support autosizing upward. I also think I may have found a bug in the logic where it clips at large font sizes. Stay tuned.

@dannymcpherson
Copy link
Author

@msahyoun - I just pushed a commit that improves the logic so that we use the largest font size that fits, where the font size is between 4 and 300 (the apparent max used by acrobat pro).

asfgit pushed a commit that referenced this pull request Dec 23, 2019
@msahyoun
Copy link

@dannymcpherson the feature has been fixed in PDFBOX-3812 and release for 2.0.21 and 3.0.0 - can you close the request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants