[flink] Replace legacy SourceFunction with v2 Source #4614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JingsongLi
reviewed
Dec 2, 2024
|
|
||
| public MonitorSource( | ||
| ReadBuilder readBuilder, long monitorInterval, boolean emitSnapshotWatermark) { | ||
| this.readBuilder = readBuilder; |
There was a problem hiding this comment.
Can you extract implementation in common, let all flink 1.x share codes.
There was a problem hiding this comment.
In future paimon-flink-common will rely on flink 2.0, which will not provide SourceFunction as public API. Where can we place the common MonitorSource in this case?
There was a problem hiding this comment.
I mean, you can extract a class implementation without SourceFunction, just for reusing codes.
JingsongLi
reviewed
Dec 2, 2024
| * <ol> | ||
| * <li>Consumer-id: rely on this function to do aligned snapshot consumption, and ensure that all | ||
| * data in a snapshot is consumed within each checkpoint. | ||
| * <li>Snapshot-watermark: when there is no watermark definition, the default Paimon table will |
There was a problem hiding this comment.
Can you add comment? Why Flink 2.0 can support this in Source API?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #4442
This PR replaces legacy SourceFunction with FLIP-27 Source.
Tests
Existing test cases are used to verify this change.
API and Format
This change does not affect API or storage format.
Documentation
This change does not affect introduce a new feature.