Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdio.h:Remove unnecessary header file #14697

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anjiahao1
Copy link
Contributor

Summary

remove unnecessary header file in stdio.h

Impact

Many compilation configs rely on removing redundant header files in stdio

Testing

build with sim:nsh

@github-actions github-actions bot added Area: File System File System issues Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Nov 8, 2024
@anjiahao1
Copy link
Contributor Author

#14260 will fix this issues

@anjiahao1
Copy link
Contributor Author

image

how to skip it, and pass ci?

@xiaoxiang781216
Copy link
Contributor

image

how to skip it, and pass ci?

let's ignore the false alarm, but the build break need be fixed.

libs/libc/stdio/lib_getstream.c Outdated Show resolved Hide resolved
include/stdio.h Outdated Show resolved Hide resolved
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the title since you are both adding and removing header files

Error: net/telnet.c:725:11: error: implicit declaration of function 'lib_free' [-Werror=implicit-function-declaration]
  725 |           lib_free(devpath);
      |           ^~~~~~~~

Error: /github/workspace/sources/nuttx/libs/libc/netdb/lib_netdb.h:117:1: error: unknown type name 'bool'
  117 | bool convert_hostent(FAR const struct hostent_s *in,
      | ^~~~

pthread_sigmask and pthread_kill just include <signal.h>
https://pubs.opengroup.org/onlinepubs/009695299/functions/pthread_sigmask.html

Signed-off-by: anjiahao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: File System File System issues Area: Networking Effects networking subsystem Area: OS Components OS Components issues Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants