-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdio.h:Remove unnecessary header file #14697
Open
anjiahao1
wants to merge
1
commit into
apache:master
Choose a base branch
from
anjiahao1:110801
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+85
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: File System
File System issues
Area: OS Components
OS Components issues
Size: M
The size of the change in this PR is medium
labels
Nov 8, 2024
#14260 will fix this issues |
anchao
requested changes
Nov 13, 2024
xiaoxiang781216
approved these changes
Nov 14, 2024
jerpelea
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the title since you are both adding and removing header files
Error: net/telnet.c:725:11: error: implicit declaration of function 'lib_free' [-Werror=implicit-function-declaration] 725 | lib_free(devpath); | ^~~~~~~~ Error: /github/workspace/sources/nuttx/libs/libc/netdb/lib_netdb.h:117:1: error: unknown type name 'bool' 117 | bool convert_hostent(FAR const struct hostent_s *in, | ^~~~ pthread_sigmask and pthread_kill just include <signal.h> https://pubs.opengroup.org/onlinepubs/009695299/functions/pthread_sigmask.html Signed-off-by: anjiahao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: File System
File System issues
Area: Networking
Effects networking subsystem
Area: OS Components
OS Components issues
Size: M
The size of the change in this PR is medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove unnecessary header file in stdio.h
Impact
Many compilation configs rely on removing redundant header files in stdio
Testing
build with sim:nsh