Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSCMPUB-63] Rely on DefaultScmRepositoryConfigurator for extracting credentials from #29

Conversation

kwin
Copy link
Member

@kwin kwin commented Feb 2, 2024

server settings

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSCMPUBLISH-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSCMPUBLISH-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin requested a review from michael-o February 2, 2024 16:16
@kwin kwin changed the title Rely on DefaultScmRepositoryConfigurator for extracting credentials from [MSCMPUB-63] Rely on DefaultScmRepositoryConfigurator for extracting credentials from Feb 8, 2024
@kwin kwin marked this pull request as ready for review February 8, 2024 14:21
@michael-o
Copy link
Member

That easy? No test necessary? Do ITs cover it already?

@kwin
Copy link
Member Author

kwin commented Feb 8, 2024

There is no IT deploying to an actual remote SCM. Only local SVN file URLs are being used. Those work without requiring credentials. Not sure if it is worth the effort to add a unit test for resolving of server settings....

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's go!

@kwin kwin merged commit f431e9e into master Feb 9, 2024
24 of 48 checks passed
@kwin kwin deleted the feature/rely-on-defaultscmrepositoryconfigurator-for-server-settings branch February 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants