-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: saga annotation #6973
base: 2.x
Are you sure you want to change the base?
feature: saga annotation #6973
Conversation
link: #5300 Changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6973 +/- ##
============================================
- Coverage 52.61% 52.60% -0.02%
+ Complexity 6590 6579 -11
============================================
Files 1126 1124 -2
Lines 40004 39969 -35
Branches 4696 4688 -8
============================================
- Hits 21050 21024 -26
+ Misses 16946 16938 -8
+ Partials 2008 2007 -1
|
/** | ||
* The interface saga action. | ||
*/ | ||
@LocalTCC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么还要用@LocalTCC,注解化saga应该跟TCC有明显的类名和注解的区分
Why use @LocalTCC? Annotated saga should be clearly distinguished from TCC by class names and annotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saga annotation is generally used for rpc, localTcc will be parsed into remote bean, for the convenience of testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, use class annotation instead.
org.apache.seata.saga.rm.SagaAnnotationResourceManager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whether the SPI interface in the compatibility package are no longer supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we hope to upgrade to the Apache package to use the new features. The compatibility package is not a long solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RegisterResourceParser design is too complex, currently only used in tcc proxy registry, and there are few scenarios for extended use, so it is decide not compatible
# Conflicts: # changes/en-us/2.x.md
Support the two-phase transaction of saga annotation.
CompensationBusinessAction
, which needs to be added to the service interface or implementation of the saga mode branch transactionIn order to support the above functions, we have also made the following changes/optimizations:
DefaultResouecePasser
will cause a resource to be registered multiple times; in order to avoid excessive abstraction and reduce the complexity of parsing cost, i was removed it.