Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-23708 testAutomaticRebalanceIfMajorityIsLost is flaky #4747

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JAkutenshi
Copy link
Contributor

JIRA Ticket: IGNITE-23708

The goal

The main goal of the PR is to fix testAutomaticRebalanceIfMajorityIsLost:

  1. Reset rebalance may be slower a little than expected 2s timeout on assertRealAssignments(node0, partId, 1) especially after IGNITE-22036 changes.
  2. There is unnecessary planned rebalance with the same planned assignments as pending force reset assignments set equals to [1]. This leads also to a flacky non-null result on assertNull(getPendingAssignments(node0, partId)) check.

The reason

Tests shouldn't be flacky and flawed implementation should be fixed.

The solution

  1. assertRealAssignments's timeout is increased up to 5s.
  2. If during GroupUpdateRequest#partitionUpdate if there are alive nodes we have equal part and stable assignments we shouldn't schedule the redundant rebalance and then should put just null then.

@sanpwc sanpwc changed the title IGNITE-23708 testAutomaticRebalanceIfMajorityIsLost is flacky IGNITE-23708 testAutomaticRebalanceIfMajorityIsLost is flaky Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant