IGNITE-23708 testAutomaticRebalanceIfMajorityIsLost is flaky #4747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-23708
The goal
The main goal of the PR is to fix
testAutomaticRebalanceIfMajorityIsLost
:assertRealAssignments(node0, partId, 1)
especially after IGNITE-22036 changes.[1]
. This leads also to a flacky non-null result onassertNull(getPendingAssignments(node0, partId))
check.The reason
Tests shouldn't be flacky and flawed implementation should be fixed.
The solution
assertRealAssignments
's timeout is increased up to 5s.GroupUpdateRequest#partitionUpdate
if there are alive nodes we have equalpart
andstable
assignments we shouldn't schedule the redundant rebalance and then should put justnull
then.