IGNITE-23674: Sql. Expose underlying schema used by RowFactory #4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowka
force-pushed
the
ignite-23674
branch
3 times, most recently
from
6eb3a46
to
0691265
Compare
AMashenkov
reviewed
Nov 19, 2024
Comment on lines
+386
to
+387
| @Nullable | ||
| Object get(int field) { |
There was a problem hiding this comment.
Suggested change
| @Nullable | |
| Object get(int field) { | |
| @Nullable Object get(int field) { |
AMashenkov
approved these changes
Nov 19, 2024
Do not make public.
lowka
commented
Nov 19, 2024
| @@ -199,7 +205,7 @@ public abstract static class RowWrapper { | |||
| /** | |||
| * Wrapper over an array of objects. | |||
| */ | |||
| private static class ObjectsArrayRowWrapper extends RowWrapper { | |||
| public static class ObjectsArrayRowWrapper extends RowWrapper { | |||
There was a problem hiding this comment.
I think these changes are unnecessary.
xtern
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
RowFactory::rowSchemamethod.https://issues.apache.org/jira/browse/IGNITE-23674
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes