Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation duration not applied for pie charts #20193

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michaelwittmann
Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR aims to fix a bug that prevents animationDuration and animationUpdateDuration defined on option level to be applied.

Fixed issues

#20192

Details

Before: What was the problem?

See bug description in #20192

After: How does it behave after the fixing?

See: https://github.com/michaelwittmann/echarts/blob/3bcc9368f4206fdadafb5a07a391777301b9f75e/test/pie-animation.html

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jul 23, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pie series has special default animation duration values. If you want to fix #20192, make sure that this default is used when neither the option-level nor the series-level animation duration value is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants