Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update text and example #17480

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

ektravel
Copy link
Contributor

This PR updates the consumer properties section of the Apache Kafka ingestion topic. Specifically, it updates the dynamic config provider example and clarifies how the isolation.level property affects the way Druid reads transactional messages.

This PR has:

  • [ x ] been self-reviewed.

Copy link
Contributor

@writer-jill writer-jill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, looks good!

docs/ingestion/kafka-ingestion.md Outdated Show resolved Hide resolved
docs/ingestion/kafka-ingestion.md Outdated Show resolved Hide resolved
docs/ingestion/kafka-ingestion.md Outdated Show resolved Hide resolved
@daveklein
Copy link

I reviewed this from a Kafka user perspective and it looks good to me.

Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest minor edit.

docs/ingestion/kafka-ingestion.md Outdated Show resolved Hide resolved
docs/ingestion/kafka-ingestion.md Outdated Show resolved Hide resolved
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techdocsmith techdocsmith merged commit bd93d00 into apache:master Nov 21, 2024
10 checks passed
@techdocsmith techdocsmith deleted the docs-kafka-security branch November 21, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants