docs: update sysmon to oshisysmon in reference docs #15258
Conversation
|
@hardikbajaj would you mind taking a look and confirming that this change is needed since you opened the PR that added Oshi. |
|
Hey @317brian , the updated Documentation for OshiSysMonitor is merged and added in 28.0 milestone #14912. I think i missed to add these changes in that PR, it would be needed, but can we keep config for both SysMonitor and OshiSysMonitor, and mark SysMonitor as deprecated. We're doing this everywhere. |
|
Fixed. PTAL @hardikbajaj |
|
@@hardikbajaj PTAL |
There was a problem hiding this comment.
@317brian One miner nit, rest LGTM. @abhishekagarwal87 can you also have a look here if this looks good to you
Cool, thanks for taking a look! I think GitHub ate your feedback for the nit though. I don't see it 😬 |
|
Ping @abhishekagarwal87 |
| @@ -106,7 +106,7 @@ There are four JVM parameters that we set on all of our services: | |||
| - The temp directory should not be volatile tmpfs. | |||
| - This directory should also have good read and write speed. | |||
| - Avoid NFS mount. | |||
| - The `org.apache.druid.java.util.metrics.SysMonitor` requires execute privileges on files in `java.io.tmpdir`. If you are using the system monitor, do not set `java.io.tmpdir` to `noexec`. | |||
| - The `org.apache.druid.java.util.metrics.OshiSysMonitor` and `org.apache.druid.java.util.metrics.SysMonitor` both require execute privileges on files in `java.io.tmpdir`. If you are using the system monitor, do not set `java.io.tmpdir` to `noexec`. Note that SysMonitor is deprecated. We recommend using OshiSysMonitor. | |||
There was a problem hiding this comment.
@hardikbajaj - do you know if the OshiSysMonitor needs this privilege?
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
This pull request/issue has been closed due to lack of activity. If you think that |
#14359 in 27.0.0 added OshiSysMonitor support to Druid, and Druid deprecated support for SysMonitor.
The reference docs still refer to SysMonitor. Since we didn't provide any additional migration steps beyond saying to include the correct module, I think we only need to update the config names in the reference page.
If this change isn't needed and the config name is staying the same, we should probably note that instead so people don't get confused.