[bugfix]Fix a mismatch between the type of jdbc query result and the datatype #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNSimba
reviewed
Nov 18, 2024
| "bigintColumn" + | ||
| " from `datagen`" + | ||
| " inner join `doris_lookup` FOR SYSTEM_TIME AS OF datagen.proctime on datagen.id = doris_lookup.id").print(); | ||
| env.execute("Flink doris lookup test"); |
There was a problem hiding this comment.
How do we judge whether this result is in line with expectations?
There was a problem hiding this comment.
You can run the test case in the previous code and the bug will show up
There was a problem hiding this comment.
This test appears to run continuously and not complete automatically?
There was a problem hiding this comment.
yes，this is a streaming job.
There was a problem hiding this comment.
This may be a problem because it will cause the test case to fail to complete.
There was a problem hiding this comment.
Ok, I'll change it later
|
Thanks for your contribution, some CI failed, @Zhumengze PTAL |
added 4 commits
November 18, 2024 16:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
The value type obtained by rs.getObject(index + 1) is inconsistent with the field type obtained by flink Context, resulting in a conversion failure in encapsulating flink RowData. For example, the java type corresponding to TINYINT is Java.lang. Byte, while the java type obtained by rs.getObject(index + 1) is Java.lang. Integer, which has a type conversion problem. SMALLINT had the same problem.
Checklist(Required)
NO
YES
NO
NO
NO
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...