Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] revert pr 479 to remove resolvedFilterQuery in DorisSource #497

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

JNSimba
Copy link
Member

@JNSimba JNSimba commented Oct 11, 2024

Proposed changes

Issue Number: close #xxx

Problem Summary:

#495 Fixed the error of unionall, so it can revert #479
Because DorisSource's resolvedFilterQuery and DorisReadOptiosn's filterQuery will cause confusion

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

# Conflicts:
#	flink-doris-connector/src/main/java/org/apache/doris/flink/source/DorisSource.java
@JNSimba JNSimba merged commit 3d13c7f into apache:master Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants