GH-43680: [Integration] Unskip nanoarrow in IPC integration tests #43715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
pitrou
requested changes
Aug 19, 2024
bkietz
force-pushed
the
nanoarrow-integration-tests
branch
from
8cce89d
to
94dd868
Compare
|
Just a few notes from some investigating:
--- a/dev/archery/archery/integration/tester_nanoarrow.py
+++ b/dev/archery/archery/integration/tester_nanoarrow.py
@@ -56,8 +56,8 @@ class NanoarrowTester(Tester):
'JSON_PATH': json_path,
'COMMAND': command,
**{
- f'QUIRK_{q}': 1
- for q in quirks or []
+ f'QUIRK_{q}': "1"
+ for q in quirks or ""
},
|
|
bkietz
force-pushed
the
nanoarrow-integration-tests
branch
from
de12a7a
to
b855bb3
Compare
|
After apache/arrow-nanoarrow#627 and apache/arrow-nanoarrow#626, I believe all the integration tests targeting the monorepo implementations will pass. There are still failures for nanoarrow producing/nanoarrow consuming, but I think those are better solved there once this PR is merged since we have the CI job set up to pull from arrow main and build a fresh nanoarrow for each commit on a PR. # From a checkout of this PR
export gold_dir=$(pwd)/../arrow-testing/data/arrow-ipc-stream/integration
export ARROW_NANOARROW_PATH=$(pwd)/../arrow-nanoarrow/build
archery integration --with-nanoarrow 1 --run-ipc \
--gold-dirs=$gold_dir/0.14.1 \
--gold-dirs=$gold_dir/0.17.1 \
--gold-dirs=$gold_dir/1.0.0-bigendian \
--gold-dirs=$gold_dir/1.0.0-littleendian \
--gold-dirs=$gold_dir/2.0.0-compression \
--gold-dirs=$gold_dir/4.0.0-shareddict |
|
...and there are still Rust failures due to google/flatbuffers#8150 (originally reported as apache/arrow-rs#5052 ). |
|
This failure is due to nanoarrow's reliance on post-0.15 stream continuations and this one is because pre 1.0 unions had null bufffers, which adds one more buffer per union field than we expect |
paleolimbot
added a commit
to apache/arrow-nanoarrow
that referenced
this pull request
Sep 20, 2024
Similar to #626 but for union type_id arrays. This should fix the two remaining failures in the integration tests between the IPC implementations in the Arrow repository and the nanoarrow IPC implementation apache/arrow#43715.
paleolimbot
approved these changes
Sep 20, 2024
github-actions
bot
added
awaiting merge
pitrou
reviewed
Sep 24, 2024
| 'COMMAND': command, | ||
| **{ | ||
| f'QUIRK_{q}': "1" | ||
| for q in quirks or "" |
There was a problem hiding this comment.
Nit (Python strings are sequences, but still)
Suggested change
| for q in quirks or "" | |
| for q in quirks or () |
There was a problem hiding this comment.
👍 will merge after CI is green again
Co-authored-by: Antoine Pitrou <[email protected]>
github-actions
bot
added
awaiting changes
|
CI failure unrelated. Merging |
|
nanoarrow / rust integration tests are failing now it seems: apache/arrow-rs#6448 Do we know if the underlying issue is tracked anywhere? |
|
I believe it's apache/arrow-rs#5052 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Nanoarrow can now read and write IPC files as of apache/arrow-nanoarrow#585 so it should no longer be skipped as a producer/consumer
What changes are included in this PR?
Nanoarrow's tester is updated to point to the new integration executable and to report nanoarrow as a consumer/producer of IPC files.
Notably the
null_trivialcase is skipped even though nanoarrow nominally supports it since it represents a corner case in which nanoarrow's flatbuffers library will not accept some vectors produced by other flatbuffers libraries dvidelabs/flatcc#287Are these changes tested?
Yes
Are there any user-facing changes?
No