Return None when Parquet page indexes are not present in file
#6639
+42
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tustvold
approved these changes
Oct 29, 2024
tustvold
added
api-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6447. Also see #6582.
Rationale for this change
The behavior of
ParquetMetaDataReaderwhen requesting page indexes differs between synchronous and asynchronous implementations. For historical reasons, the synchronous methods currently return empty vectors for theColumnIndexandOffsetIndexwhen page indexes are requested but not present in the file. The asynchronous methods instead returnNonein that case.What changes are included in this PR?
This PR changes the behavior of
ParquetMetaDataReaderto always returnNonewhen page indexes are requested but not present. It also changes the behavior and signatures of the legacy functionsread_columns_indexesandread_offset_indexes. These will now return optional vectors set toNonerather than empty vectors when page indexes are not present.Are there any user-facing changes?
Yes, as noted above.