Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

fix #538 - make /opt/spark/work-dir writable by gid 0 #560

Open
wants to merge 1 commit into
base: branch-2.2-kubernetes
Choose a base branch
from

Conversation

erikerlandson
Copy link
Member

What changes were proposed in this pull request?

make /opt/spark/work-dir writable by gid 0 to operate better in anonymous uid scenarios

(Please fill in changes proposed in this fix)

How was this patch tested?

I'm using CI infra to fully test image creation and exercising via the unit/integration tests

@erikerlandson
Copy link
Member Author

Note, altering the permissions of /opt/spark/work-dir appears to be sufficient, not all of $SPARK_HOME as I assumed originally when I wrote up #538

@erikerlandson
Copy link
Member Author

Tangentially, I fixed a missing && after mkdir -p /opt/spark/work-dir - which makes me wonder what that RUN complex was actually doing

@erikerlandson
Copy link
Member Author

@foxish ptal - also curious what you think about the missing && that was there

@foxish
Copy link
Member

foxish commented Dec 6, 2017

Do we need this to go into the upstream as well? apache#19717 has the spark-base docker-file within the PR.

@foxish
Copy link
Member

foxish commented Dec 6, 2017

I think for people looking to customize the image using ours as base, this might be an issue - to have the owner be root. I had a discussion on the thread with Mridul in apache#19717 (comment). Assuming that it'll be root might be tenuous when someone uses PodSecurityPolicy to enforce a certain user.

cc @liyinan926

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants