Merge pull request #155 from aopell/develop

Version 5.3.1

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,24 @@
+---
+name: Bug report
+about: 'Report a bug you found in Schoology Plus. PLEASE NOTE: Only use issues for
+  bug reports, submit feature requests through our Discord server only please.'
+title: ''
+labels: Bug
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Additional context**
+Add any other context about the problem here.

js/grades.js

@@ -434,7 +434,7 @@ var fetchQueue = [];
 
                 // any state change when editing has been disabled
                 if (editDisableReason) {
-                    alert("An error occurred loading assignments. Editing has been disabled.\nReason: " + editDisableReason);
+                    alert("An error occurred loading assignments. Editing has been disabled.\nReason: " + JSON.stringify(editDisableReason));
                     document.getElementById("enable-modify").checked = false;
                 }
                 // enabling editing

js/theme.js

@@ -372,7 +372,7 @@ class Theme {
             img.classList.add("injected-course-icon");
         }
 
-        if (!shownMissingIconsNotification && coursesMissingDefaultIcons.size > 0) {
+        if (!shownMissingIconsNotification && coursesMissingDefaultIcons.size > 0 && showToast) {
             let coursesString = encodeURI(Array.from(coursesMissingDefaultIcons).join("\n"));
             showToast("Request New Course Icons?",
                 `${coursesMissingDefaultIcons.size} ${coursesMissingDefaultIcons.size == 1 ? "course is missing a Schoology Plus course icon. Would you like to request that an icon be added for this course?" : "courses are missing Schoology Plus course icons. Would you like to request that icons be added for these courses?"}`,
@@ -383,7 +383,7 @@ class Theme {
                         createToastButton("No", "nothing-button", () => showToast("You can request icons later from course options", "", "hsl(190, 100%, 50%)", { timeout: 5000 })),
                     ]
                 }
-            )
+            );
             shownMissingIconsNotification = true;
             Setting.setValue("toggle_stopTrackingMissingIcons", true);
         }

manifest.json

@@ -9,7 +9,7 @@
             "update_url": "https://aopell.me/SchoologyPlus/update.json"
         }
     },
-    "version": "5.3",
+    "version": "5.3.1",
     "icons": {
         "128": "imgs/[email protected]",
         "64": "imgs/[email protected]",