Improve logging

.github/CODEOWNERS

@@ -0,0 +1 @@
+* @antonengelhardt @miwig

.github/dependabot.yml

@@ -4,12 +4,34 @@
 # https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
 
 version: 2
+
 updates:
-  - package-ecosystem: "cargo" # See documentation for possible values
-    directory: "/" # Location of package manifests
+  # This checks for minor and major version updates every week
+  - package-ecosystem: "cargo"
+    directory: "/"
     labels:
       - "dependencies"
     schedule:
       interval: "weekly"
-    reviewers: 
+    reviewers:
       - "antonengelhardt"
+    ignore:
+      - dependency-name: "*"
+        update-types:
+          - "version-update:semver-patch"
+
+  # Patches are grouped together into one PR every month
+  # - package-ecosystem: "cargo"
+  #   directory: "/"
+  #   labels:
+  #     - "dependencies"
+  #   schedule:
+  #     interval: "monthly"
+  #   reviewers:
+  #     - "antonengelhardt"
+
+  #   # Group all patches into one PR
+  #   groups:
+  #     patches:
+  #       update-types:
+  #         - "patch"

.github/workflows/build.yml

@@ -108,7 +108,7 @@ jobs:
             target/
           key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
 
-      - name: Build WASM OIDC Plugin
+      - name: Build wasm-oidc-plugin
         run: |
           cargo build --target wasm32-wasi --release
 
@@ -132,6 +132,9 @@ jobs:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_PASSWORD }}
 
+      - name: Pull previous image to cache
+        run: docker pull antonengelhardt/wasm-oidc-plugin:latest
+
       - name: Push to Docker Hub
         uses: docker/build-push-action@v2
         with:

.github/workflows/test.yml

@@ -105,7 +105,7 @@ jobs:
             target/
           key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
 
-      - name: Build WASM OIDC Plugin
+      - name: Build wasm-oidc-plugin
         run: |
           cargo build --target wasm32-wasi --release
 
@@ -129,6 +129,9 @@ jobs:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_PASSWORD }}
 
+      - name: Pull previous image to cache
+        run: docker pull antonengelhardt/wasm-oidc-plugin:pr-${{ github.event.pull_request.head.ref }} || true
+
       - name: Push to Docker Hub
         uses: docker/build-push-action@v2
         with:

k8s/ci.yml

@@ -110,7 +110,7 @@ jobs:
             target/
           key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
 
-      - name: Build WASM OIDC Plugin
+      - name: Build wasm-oidc-plugin
         run: |
           cargo build --target wasm32-wasi --release
 

src/cookie.rs

@@ -69,7 +69,7 @@ impl Session {
         let encrypted_cookie = cipher.encrypt(&nonce, serde_json::to_vec(&self)?.as_slice())?;
         let encoded_cookie = base64engine.encode(encrypted_cookie.as_slice());
 
-        debug!("Encrypted with nonce: {}", &encoded_nonce);
+        debug!("encrypted with nonce: {}", &encoded_nonce);
 
         Ok((encoded_cookie, encoded_nonce))
     }
@@ -148,7 +148,7 @@ impl Session {
         encoded_nonce: String,
     ) -> Result<Session, PluginError> {
         // Decode nonce using base64
-        debug!("Decrypting with nonce: {}", encoded_nonce);
+        debug!("decrypting with nonce: {}", encoded_nonce);
         let decoded_nonce = base64engine.decode(encoded_nonce.as_bytes())?;
         let nonce = aes_gcm::Nonce::from_slice(decoded_nonce.as_slice());
 
@@ -160,7 +160,7 @@ impl Session {
 
         // Parse cookie into a struct
         let state = serde_json::from_slice::<Session>(&decrypted_cookie)?;
-        debug!("State: {:?}", state);
+        debug!("state: {:?}", state);
         Ok(state)
     }
 }

src/lib.rs

@@ -124,7 +124,7 @@ impl HttpContext for ConfiguredOidc {
             .iter()
             .any(|x| x.is_match(&host))
         {
-            debug!("Host {} is excluded. Forwarding request.", host);
+            debug!("host {} is excluded, forwarding request.", host);
             self.filter_proxy_cookies();
             return Action::Continue;
         }
@@ -136,7 +136,7 @@ impl HttpContext for ConfiguredOidc {
             .iter()
             .any(|x| x.is_match(&path))
         {
-            debug!("Path {} is excluded. Forwarding request.", path);
+            debug!("path {} is excluded, forwarding request.", path);
             self.filter_proxy_cookies();
             return Action::Continue;
         }
@@ -149,7 +149,7 @@ impl HttpContext for ConfiguredOidc {
             .iter()
             .any(|x| x.is_match(url.as_str()))
         {
-            debug!("Url {} is excluded. Forwarding request.", url.as_str());
+            debug!("url {} is excluded, forwarding request.", url.as_str());
             self.filter_proxy_cookies();
             return Action::Continue;
         }
@@ -221,9 +221,12 @@ impl HttpContext for ConfiguredOidc {
                 // Allow request to pass
                 return Action::Continue;
             }
-            Err(e) => {
-                warn!("cookie validation failed: {}", e);
-            }
+            Err(e) => match e {
+                // disable logging for these errors
+                PluginError::SessionCookieNotFoundError => {}
+                PluginError::NonceCookieNotFoundError => {}
+                _ => warn!("cookie validation failed: {}", e),
+            },
         }
 
         // Redirect to `authorization_endpoint` if no cookie is found or previous cases have returned an error.
@@ -399,7 +402,7 @@ impl ConfiguredOidc {
             match validation_result {
                 Ok(_) => return Ok(()),
                 Err(e) => {
-                    debug!("Token validation failed: {:?}", e);
+                    debug!("token validation failed: {:?}", e);
                     continue;
                 }
             }
@@ -432,9 +435,9 @@ impl ConfiguredOidc {
         )?;
 
         // Get state and code from query
-        let state = callback_params.state;
         let code = callback_params.code;
         debug!("authorization code: {}", code);
+        let state = callback_params.state;
         debug!("client state: {}", state);
         debug!("cookie state: {}", session.state);
 
@@ -532,8 +535,8 @@ impl ConfiguredOidc {
         match self.get_http_call_response_body(0, body_size) {
             Some(body) => {
                 // Get nonce and cookie
-                let encoded_nonce = self.get_nonce()?;
                 let encoded_cookie = self.get_session_cookie_as_string()?;
+                let encoded_nonce = self.get_nonce()?;
 
                 // Get session from cookie
                 let mut session = Session::decode_and_decrypt(