Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LT8491 #2639

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jemfgeronimo
Copy link

PR Description

  • This adds driver support, and device tree bindings for LT8491 Battery Charge Controller
  • Datasheet: LT8491
  • Tested on RPI4 with DC2703A

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it goes my first round

description: Resistance value of RFBIN2 in ohms.

adi,rfbin1-ohms:
description: Resistance value of RFBIN1 in ohms.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any constrains for the resistor values (or default values)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the actual resistor values used in the circuit/PCB.

- adi,rfbout2-ohms
- adi,rdaci-ohms
- adi,rfbin2-ohms
- adi,rfbin1-ohms
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure. Are all these properties really mandatory?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. These are needed for the measurements of telemetry data such as temperature, voltage, current, and power.

drivers/power/supply/lt8491_charger.c Outdated Show resolved Hide resolved
drivers/power/supply/lt8491_charger.c Show resolved Hide resolved
drivers/power/supply/lt8491_charger.c Outdated Show resolved Hide resolved
drivers/power/supply/lt8491_charger.c Outdated Show resolved Hide resolved
drivers/power/supply/lt8491_charger.c Outdated Show resolved Hide resolved
drivers/power/supply/lt8491_charger.c Outdated Show resolved Hide resolved
drivers/power/supply/lt8491_charger.c Outdated Show resolved Hide resolved
drivers/power/supply/lt8491_charger.c Outdated Show resolved Hide resolved
Add documentation for devicetree bindings for LT8491

Signed-off-by: John Erasmus Mari Geronimo <[email protected]>
LT8491 High Voltage Buck-Boost Battery Charge Controller with I2C

Signed-off-by: John Erasmus Mari Geronimo <[email protected]>
Add entry for the LT8491 driver.

Signed-off-by: John Erasmus Mari Geronimo <[email protected]>
@jemfgeronimo
Copy link
Author

jemfgeronimo commented Nov 20, 2024

V2

  • dt-bindings: fixed some property descriptions
  • removed i2c_set_clientdata and i2c_get_clientdata
  • removed lt8491_update_telemetry() helper
  • fixed serial number reading
  • fixed signedness of temperature values
  • added mutex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants