-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LT8722 #2637
base: main
Are you sure you want to change the base?
Add support for LT8722 #2637
Conversation
792b158
to
7be3866
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here it goes my first round
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
drivers/regulator/lt8722-regulator.c
Outdated
return ret; | ||
|
||
reg_val &= ~mask; | ||
reg_val |= (val << __ffs(mask)) & mask; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of open coding FIELD_PREP(). Can we make sure val
is already properly set (in the same way we would pass it to regmap_update_bits()) and then have a one liner:
reg_val = (reg_val & ~mask) | (reg_val & mask);
c5bb8db
to
bd3502a
Compare
V2: DT Bindings
Kconfig
Driver
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better. take my inputs and send it upstream... I think it's already good enough to be sent. Of course you'll get more feedback from the maintainers.
Documentation/devicetree/bindings/regulator/adi,lt8722-regulator.yaml
Outdated
Show resolved
Hide resolved
bd3502a
to
ce61751
Compare
imply REGULATOR_LT8722. Signed-off-by: Ramon Cristopher M. Calam <[email protected]>
Add ADI LT8722 full bridge DC/DC converter driver support. Signed-off-by: Ramon Cristopher M. Calam <[email protected]>
c591733
to
e09f688
Compare
Add documentation for devicetree bindings for LT8722. Signed-off-by: Ramon Cristopher M. Calam <[email protected]>
e09f688
to
e7e58cf
Compare
PR Description
PR Type
PR Checklist