add support for ltc4162-f/s and ltc4015 battery charger #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseerp
requested review from
nunojsa,
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
kseerp
changed the title
nunojsa
reviewed
Sep 20, 2024
|
Also, the things I mentioned as "nice to have" is up to you to add it or not :) |
Add support for ltc4162-f/s and ltc4015 - Add compatible entries for ltc4162-f/s and ltc4015 - Include datasheets for new devices Signed-off-by: Kim Seer Paller <[email protected]>
Add support for LTC4162-F 35V/3.2A Multi-Cell LiFePO4 Step-Down Battery Charger LTC4162-S 35V/3.2A Lead-Acid Step-Down Battery Charger LTC4015 35V/3.2A Multichemistry Buck Battery Charger Controller Add chip_info struct to hold the chip specific data. Modify functions for battery voltage/current, input voltage/current, charge voltage, die temp, and force telemetry to handle different battery chemistries. Signed-off-by: Kim Seer Paller <[email protected]>
|
v2
|
nunojsa
reviewed
Oct 22, 2024
| @@ -840,6 +1153,12 @@ static int ltc4162l_probe(struct i2c_client *client, | |||
| info->client = client; | |||
| i2c_set_clientdata(client, info); | |||
|
|
|||
| chip_info = device_get_match_data(dev); | |||
There was a problem hiding this comment.
when upstreaming use i2c_get_match_data()
| @@ -820,12 +1131,14 @@ static void ltc4162l_clear_interrupts(struct ltc4162l_info *info) | |||
| } | |||
|
|
|||
| static int ltc4162l_probe(struct i2c_client *client, | |||
| const struct i2c_device_id *id) | |||
| const struct i2c_device_id *id) | |||
There was a problem hiding this comment.
This is a stylistic change... You have more in this patch. Do them in a different patch (like a follow up one)
| size_t count) | ||
| struct device_attribute *attr, | ||
| const char *buf, | ||
| size_t count) |
| return sprintf(buf, "%u\n", | ||
| regval == LTC4162L_ARM_SHIP_MODE_MAGIC ? 1 : 0); | ||
| return sysfs_emit(buf, "%u\n", | ||
| regval == LTC4162L_ARM_SHIP_MODE_MAGIC ? 1 : 0); |
|
|
||
| return count; | ||
| return ret ? ret : count; |
| @@ -98,7 +138,7 @@ static u8 ltc4162l_get_cell_count(struct ltc4162l_info *info) | |||
| return 0; | |||
|
|
|||
| /* Lower 4 bits is the cell count, or 0 if the chip doesn't know yet */ | |||
| val &= 0x0f; | |||
| val = FIELD_GET(LTC4162L_CELL_COUNT_MASK, val); | |||
There was a problem hiding this comment.
This is also not related with addition of the new devices...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add support for:
LTC4162-F 35V/3.2A Multi-Cell LiFePO4 Step-Down Battery Charger
LTC4162-S 35V/3.2A Lead-Acid Step-Down Battery Charger
LTC4015 35V/3.2A Multichemistry Buck Battery Charger Controller
Bindings:
ltc4162:
charge voltage, die temp, and force telemetry to handle different
battery chemistries.
PR Type
PR Checklist