Skip to content

Commit

Permalink
Pin requests due to bug with connecting to DVLA
Browse files Browse the repository at this point in the history
We updated requests in #4108
but we saw errors in production connecting to DVLA as per
psf/requests#6730.

It looks like moving back to 2.32.2 should be unaffected, at least
according to the github issue above.

Once a new version is released that fixes it, we can drop this
pin. If it doesn't get fixed we could look at an alternative approach
like #4113
  • Loading branch information
idavidmcdonald committed Jun 18, 2024
1 parent 2a14ae8 commit b707247
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ itsdangerous==2.1.2
jsonschema[format]==4.16.0
marshmallow-sqlalchemy==0.28.1
marshmallow==3.18.0
# Requests pinned to 2.32.2 until https://github.com/psf/requests/issues/6730 is fixed. Once so, we can remove this pin
requests==2.32.2
psycopg2-binary==2.9.6
PyJWT==2.5.0
SQLAlchemy==1.4.41
Expand Down
3 changes: 2 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,9 @@ pyyaml==6.0.1
# via notifications-utils
redis==4.5.4
# via flask-redis
requests==2.32.3
requests==2.32.2
# via
# -r requirements.in
# govuk-bank-holidays
# notifications-python-client
# notifications-utils
Expand Down

0 comments on commit b707247

Please sign in to comment.