SKYEDEN-3234 detect unused topics #1922
Open
+1,324
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
questras
commented
Nov 12, 2024
•
questras
commented
- Add a cron job to detect inactive topics and notify them
- notification thresholds, cron etc are configured via properties
- Notifier implementation is not provided, but the feature can work without it
- the job runs on one instance of hermes management only, based on provided ZK datacenter for leadership election (in properties)
moscicky
previously approved these changes
Nov 19, 2024
| public record InactiveTopic( | ||
| @JsonProperty String qualifiedTopicName, | ||
| @JsonProperty long lastPublishedMessageTimestampMs, | ||
| @JsonProperty List<Long> notificationTimestampsMs, |
There was a problem hiding this comment.
Wondering if it is necessary to keep all notification history as it can grow indefinitely. Perhaps we can persist only previous notification time? what do you think?
There was a problem hiding this comment.
It was my first thought but I decided to keep a list as it also tells you how many times you've already notified the topic, which might be useful.
What do you think about providing a configurable limit (via properties) of the list size? this way you still keep the history but it doesn't grow indefinitely
There was a problem hiding this comment.
Sure, we can go with bounded list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.