New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allegro-internal/flex-roadmap#601 Added test to check metric value #415

Merged

nastassia-dailidava merged 2 commits into master from cb-test

Apr 29, 2024

Contributor

nastassia-dailidava commented Apr 25, 2024 •

edited

Loading

closes allegro-internal/flex-roadmap#601
a test to check remaining_pending metric

nastassia-dailidava added 2 commits

April 25, 2024 20:37


          allegro-internal/flex-roadmap#601 Added test to check metric value

f64e072


          allegro-internal/flex-roadmap#601 Added test to check metric value

ec0e58b

Collaborator

kozjan commented Apr 29, 2024

wasn't the test you added flaky as well?
in that case pls add the tag same as here: https://github.com/allegro/envoy-control/blob/master/envoy-control-tests/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/EndpointMetadataMergingTests.kt#L14-L15

kozjan approved these changes

View reviewed changes

nastassia-dailidava merged commit 019639d into master

5 of 6 checks passed

nastassia-dailidava deleted the cb-test branch

April 29, 2024 09:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet