Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use global version #342

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

jwermuth
Copy link

@jwermuth jwermuth commented Jul 9, 2020

Thanks for a nice plugin.
This is the implementation of issue #340

It has code and tests and user documentation allowing user to do

    scmVersion {
        useGlobalVersion = true
    }

and

# ./gradlew currentVersion -Prelease.useGlobalVersion

I implemented this for a project where I need it. It would be nice with a release including it (if it passes acceptance, of course) soon.

Regards
Jesper

@coveralls
Copy link

coveralls commented Jul 9, 2020

Coverage Status

Coverage increased (+0.5%) to 57.913% when pulling 9aff1da on jwermuth:feature/useGlobalVersion into b02d6ba on allegro:master.

@jwermuth
Copy link
Author

@adamdubiel can I do anything to offload you, so this PR (regarding #340 ) can get merged

@km-at-aloteq-dev
Copy link

km-at-aloteq-dev commented Aug 3, 2020

Hi guys!

I'm also voting for this feature. It is highly required for my projects as well.

Best regards,
Konstanty


Cześć Państwu!

Oddaje też swój głos za tą funkcję! Bardzo potrzebuje ją w moich projektach!

Pozdrawiam,
Konstanty

@jwermuth
Copy link
Author

jwermuth commented Aug 3, 2020

Merged the lastest changes on master ( #317 ) into feature/useGlobalVersion branch on jwermuth/axion-release-plugin. Tests are still green. @adamdubiel can I do something to get this PR merged ?

@bgalek
Copy link
Member

bgalek commented Mar 22, 2021

hi @jwermuth, thanks for Your contribution and patience!
I'll look at it and I hope we will add this feature to the next axion-release-plugin release ;)

@bgalek bgalek force-pushed the master branch 2 times, most recently from 5bfb848 to 48ce606 Compare March 29, 2021 19:50
@jwermuth
Copy link
Author

@bgalek thanks for giving my PR some attention. I have noticed that the latest code on master breaks my PR. I will start looking at it now, and push when its fixed.

@cristianrgreco
Copy link

cristianrgreco commented Aug 18, 2022

It is a shame to see this PR that was ready 2 years ago and maintained for almost 1 year has gone stale instead of being merged. This would have been very helpful for my case as well.

@grhawk
Copy link

grhawk commented Jan 30, 2023

Why is this not merged!? :( Let me know if I can help... but this would be an very appreciated feature!

@bgalek
Copy link
Member

bgalek commented Jan 30, 2023

@grhawk sure, I'll help to merge it - but i need help - you could start with rebasing this branch

@grhawk
Copy link

grhawk commented Jan 30, 2023

@bgalek I tried, this is really just a single rebase, there is nothing to merge... if I have to do it, it means that I should create a pull request to @jwermuth to just move a pointer in git. I really think the best approach is that one of you does it... I think my "help" would only make things slower and messier...

@bgalek
Copy link
Member

bgalek commented Jan 30, 2023

just fork his repo, rebase and push it as your own PR

@grhawk
Copy link

grhawk commented Jan 30, 2023

mmm I did a mistake... it actually a mess even just to merge the 2 branches... it looks like some major refactoring went on... I will have a look in the next days... but I really think this is going to be difficult!

@big-andy-coates
Copy link
Contributor

I've a question on the validity of this feature... #340 (comment)

@grhawk
Copy link

grhawk commented May 16, 2023

@bgalek hey, sorry I disappeared under tons of stuff to do... I may have time in the next couple of weeks of tackling the issue... just let me know if you are still interested in merging this... :)

@grhawk
Copy link

grhawk commented May 17, 2023

@bgalek I assume the "heart" is "yes"... but please, don't let me work on this if you are not interested in merging it :)

@bgalek
Copy link
Member

bgalek commented May 17, 2023

I'll be happy to merge it, I should be able to check everything next week

@big-andy-coates
Copy link
Contributor

I'll be happy to merge it, I should be able to check everything next week

Did you notice my question on the validity of this feature: #340 (comment)

Happy to be overruled, but wanted to highlight.

@bgalek
Copy link
Member

bgalek commented May 22, 2023

@big-andy-coates has a good point there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants