-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use global version #342
base: main
Are you sure you want to change the base?
Conversation
…release-plugin into feature/useGlobalVersion
Make it more clear which tests concern useGlobalVersion
@adamdubiel can I do anything to offload you, so this PR (regarding #340 ) can get merged |
Hi guys! I'm also voting for this feature. It is highly required for my projects as well. Best regards, Cześć Państwu! Oddaje też swój głos za tą funkcję! Bardzo potrzebuje ją w moich projektach! Pozdrawiam, |
Merged the lastest changes on master ( #317 ) into feature/useGlobalVersion branch on jwermuth/axion-release-plugin. Tests are still green. @adamdubiel can I do something to get this PR merged ? |
hi @jwermuth, thanks for Your contribution and patience! |
5bfb848
to
48ce606
Compare
@bgalek thanks for giving my PR some attention. I have noticed that the latest code on master breaks my PR. I will start looking at it now, and push when its fixed. |
It is a shame to see this PR that was ready 2 years ago and maintained for almost 1 year has gone stale instead of being merged. This would have been very helpful for my case as well. |
Why is this not merged!? :( Let me know if I can help... but this would be an very appreciated feature! |
@grhawk sure, I'll help to merge it - but i need help - you could start with rebasing this branch |
@bgalek I tried, this is really just a single rebase, there is nothing to merge... if I have to do it, it means that I should create a pull request to @jwermuth to just move a pointer in git. I really think the best approach is that one of you does it... I think my "help" would only make things slower and messier... |
just fork his repo, rebase and push it as your own PR |
mmm I did a mistake... it actually a mess even just to merge the 2 branches... it looks like some major refactoring went on... I will have a look in the next days... but I really think this is going to be difficult! |
I've a question on the validity of this feature... #340 (comment) |
@bgalek hey, sorry I disappeared under tons of stuff to do... I may have time in the next couple of weeks of tackling the issue... just let me know if you are still interested in merging this... :) |
@bgalek I assume the "heart" is "yes"... but please, don't let me work on this if you are not interested in merging it :) |
I'll be happy to merge it, I should be able to check everything next week |
Did you notice my question on the validity of this feature: #340 (comment) Happy to be overruled, but wanted to highlight. |
@big-andy-coates has a good point there |
Thanks for a nice plugin.
This is the implementation of issue #340
It has code and tests and user documentation allowing user to do
and
I implemented this for a project where I need it. It would be nice with a release including it (if it passes acceptance, of course) soon.
Regards
Jesper