Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add merge/rebase feature #139

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[WIP] Add merge/rebase feature #139

wants to merge 6 commits into from

Conversation

alexellis
Copy link
Owner

@alexellis alexellis commented Jan 16, 2020

Description

Experimental command allowing merge (read rebase) via Derek command

Motivation and Context

  • I have raised an issue to propose this change (required)

This would require additional ACL / RBAC

Raised because of backlog item: #91

How Has This Been Tested?

Tested with an older version of master with @viveksyngh e2e with a test repo.

We have two test repos:

mergers:
- people-who-can-say-derek-merge

must_approve:
- name-that-must-approve-the-pr-to-merge

https://github.com/alexellis/kumbaya/pulls

https://github.com/alexellis/two-better-than-one/pulls

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Closes: #112

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant