Break wasm-smith's default dependency on wasmparser

This fixes a mistake introduced in bytecodealliance#1330 which accidentally undid bytecodealliance#1301. Closes bytecodealliance#1383
alexcrichton · Jan 24, 2024 · fdf825a · fdf825a
1 parent 8b9ba68
commit fdf825a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -119,6 +119,11 @@ jobs:
       - run: cargo check --no-default-features --features metadata
       - run: cargo check --no-default-features --features wit-smith
       - run: cargo check --no-default-features --features addr2line
+      - run: |
+          if cargo tree -p wasm-smith --no-default-features -e no-dev | grep wasmparser; then
+            echo wasm-smith without default features should not depend on wasmparser
+            exit 1
+          fi
 
   doc:
     runs-on: ubuntu-latest

diff --git a/crates/wasm-smith/Cargo.toml b/crates/wasm-smith/Cargo.toml
@@ -24,7 +24,7 @@ indexmap = { workspace = true }
 leb128 = { workspace = true }
 serde = { workspace = true, optional = true }
 serde_derive = { workspace = true, optional = true }
-wasm-encoder = { workspace = true, features = ['wasmparser'] }
+wasm-encoder = { workspace = true }
 wasmparser = { workspace = true, optional = true }
 wat = { workspace = true, optional = true }
 
@@ -40,3 +40,4 @@ libfuzzer-sys = { workspace = true }
 
 [features]
 _internal_cli = ["anyhow", "clap", "flagset/serde", "serde", "serde_derive", "wasmparser", "wat"]
+wasmparser = ['dep:wasmparser', 'wasm-encoder/wasmparser']