Static OpenSSL option for MacOS and Windows

[rustysec]

#278 take 2!

provides feature to opt in to static openssl linkage.

[alexcrichton]

Thanks!

Could a test on CI be added for this?

Also, I'm sort of losing track of all the features the curl-sys and curl crate has, would you mind writing up some documentation in either the README.md or in the manifest iteslf?

[rustysec]

definitely, should be able to work on it later today or tomorrow.

[alexcrichton]

Thanks! I think with an update to CI to exercise this it should be good to go

[alexcrichton]

I think this should be covered by openssl-sys right?

[rustysec]

well i just discovered this pr actually isn't building right anyway. seems like without target specific features i probably won't be able to make this work without breaking changes. it's 100% possible i'm missing something obvious, however.

[alexcrichton]

Could that be fixed by perhaps just making openssl-sys always an optional dependency?

[rustysec]

it does fix my build, but it also ends up compiling openssl for every target because ssl is on by default and openssl is a dependency of that. there doesn't seem to be a great way to handle all the conditions.

[alexcrichton]

Oh right :(

Hm I'm not sure how best to configure this in that case :(

[rustysec]

i experimented locally with moving the current crate into a subfolder (curl-base) and then being able to use platform specific dependencies to turn the features on and off. there's just a one line lib.rs that re-exports the current crate. seems like i can get the same default behavior that way. it's a lot of re-organizing, not sure how you feel about that.

anyway, this whole effort may not be worth it once mesalink will build properly on windows.

[alexcrichton]

Hm yeah that may be a bit overkill for this, and if mesalink works that'd be great if that could be used!