Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source branch and hide common target branches in PR dashboard #235

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kroeschl
Copy link
Contributor

Justification

When looking at the PR dashboard, I frequently want to see the name of the source branch for a given PR. I also almost never care about the target branch, because it's usually just main or master.

Implementation

Add the source branch to all PRs. Hide the target branch (and related text and icon) if it's main or master. Also abbreviate user branch names like users/kroeschl/foo to u/k/foo to save space in the dashboard. Actually update the README and update notification.

Testing

Viewed some PRs into main and a test PR into not-main to verify rendering:
branches
Also verified that notification is updated and actually displays in browser:
notification

@alejandro5042
Copy link
Owner

alejandro5042 commented May 4, 2024

Hey! Thanks for this draft PR! Overall, I like it. Also, thanks for updating the popup.

I'm not sure about the rewriting the branch name--it would then display incorrect/misleading information. I'm down for shortening, but I'd want it to look different.

How about this?

👤/my-branch

@kroeschl
Copy link
Contributor Author

kroeschl commented May 6, 2024

How about this?

👤/my-branch

I like that idea. Something like this? Should we do something different for not-me? Or just not shorten branches for other users?
user-icon-branch

Or we could use to make it more obvious without needing to handle self vs other users differently.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants