fixes a bash syntax error with BUILD_RESTRICT_LANG and some English

12.0/Dockerfile

@@ -1,5 +1,5 @@
 FROM ghcr.io/acsone/odoo-bedrock:12.0-py37-latest
-MAINTAINER Akretion
+LABEL maintainer=Akretion
 
 # syntax = docker/dockerfile:1.4
 

13.0/Dockerfile

@@ -1,5 +1,5 @@
 FROM ghcr.io/acsone/odoo-bedrock:13.0-py37-latest
-MAINTAINER Akretion
+LABEL maintainer=Akretion
 
 # syntax = docker/dockerfile:1.4
 

14.0/Dockerfile

@@ -1,5 +1,5 @@
 FROM ghcr.io/acsone/odoo-bedrock:14.0-py38-latest
-MAINTAINER Akretion
+LABEL maintainer=Akretion
 
 # syntax = docker/dockerfile:1.4
 

15.0/Dockerfile

@@ -1,5 +1,5 @@
 FROM ghcr.io/acsone/odoo-bedrock:15.0-py38-latest
-MAINTAINER Akretion
+LABEL maintainer=Akretion
 
 # syntax = docker/dockerfile:1.4
 

16.0/Dockerfile

@@ -1,6 +1,6 @@
 # python 3.10 is the default used in acsone
 FROM ghcr.io/acsone/odoo-bedrock:16.0-py310-latest
-MAINTAINER Akretion
+LABEL maintainer=Akretion
 
 # syntax = docker/dockerfile:1.4
 

bin/ak-entrypoint.sh

@@ -15,7 +15,7 @@ export DB_NAME=${PGDATABASE}
 
 
 if [ -z "$(pip list --format=columns | grep "/odoo/src")" ]; then
-  # The build runs 'pip install -e' on the odoo src, which creates an
+  # The build runs 'pip install -e' on the odoo/src directory, which creates an
   # odoo.egg-info directory *inside /odoo/src*. So when we run a container
   # with a volume shared with the host, we don't have this .egg-info (at least
   # the first time).
@@ -30,7 +30,7 @@ if [ -z "$(pip list --format=columns | grep "/odoo/src")" ]; then
   chown -R $USER_ID:$USER_ID /odoo/src/*.egg-info
 fi
 
-# Do not block the entrypoint if the pip install fail (only local case)
-# so we only exist if fail after the pip install
+# Do not block the entrypoint if pip install fails (only local case)
+# so we only exit in case of a failure after pip install
 set -Eeuo pipefail
 /usr/local/bin/entrypoint.sh "$@"

install/build-odoo

@@ -8,17 +8,16 @@ ak build -c odoo-spec.yaml -f odoo-frozen.yaml
 # Remove useless git directory
 rm -rf /odoo/src/.git
 
-# Keep only wanted odoo module if defined
+# First, we eventually keep only the wanted odoo modules
 if [ -z "$(ls -A /odoo/links)" ]; then
-  echo "No module specify, display all"
+  echo "No addons set specified, keeping all addons"
 else
   cp -r -L /odoo/links /odoo/odoo-addons
   rm -rf /odoo/src/addons/*
   mv /odoo/odoo-addons/* /odoo/src/addons
 fi
 
-# Secondly we remove unwanted lang
-if [[ BUILD_RESTRICT_LANG ]]
-then
+# Second, we remove unwanted lang
+if [[ -n "$BUILD_RESTRICT_LANG" ]]; then
     find /odoo/src/ -name *.po ! -name $BUILD_RESTRICT_LANG -type f -exec rm -v {} +
 fi