If the chunk fails and we keep the 'slot' as free, make sure to remove the files from disk #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansu
reviewed
Nov 22, 2024
| @@ -437,6 +437,12 @@ private void handleChunkAssignment(CacheSlotMetadata cacheSlotMetadata) { | |||
| // disregarding any errors | |||
| setChunkMetadataState(cacheSlotMetadata, Metadata.CacheSlotMetadata.CacheSlotState.FREE); | |||
| LOG.error("Error handling chunk assignment", e); | |||
| // also clean up downloaded files if the chunk could not be assigned as we're marking the as | |||
| // FREE / available | |||
| if (Files.isDirectory(dataDirectory)) { | |||
There was a problem hiding this comment.
There is already a cleanDirectory method in this class that can do this. Can we call that method here?
There was a problem hiding this comment.
Also, can you please add a unit test for this case.
There was a problem hiding this comment.
cleanDirectory only deletes the files in the directory. i used that one first, but it doesn't have the desired result
autata
force-pushed
the
aubrey/cache-node
branch
from
b60a4b3
to
bfb3406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the chunk fails and we keep the 'slot' as free, make sure to remove the files from disk
Describe the goal of this PR. Mention any related Issue numbers.
Requirements