-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(addon/components/paper-grid): converts to glimmer components. #1299
Open
matthewhartstonge
wants to merge
16
commits into
feature/glimmer-paper-button
Choose a base branch
from
feature/glimmer-paper-grid-tile
base: feature/glimmer-paper-button
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(addon/components/paper-grid): converts to glimmer components. #1299
matthewhartstonge
wants to merge
16
commits into
feature/glimmer-paper-button
from
feature/glimmer-paper-grid-tile
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
20 tasks
matthewhartstonge
force-pushed
the
feature/glimmer-paper-grid-tile
branch
from
November 12, 2024 22:21
d743472
to
cc02b59
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-button
branch
from
November 12, 2024 22:49
c21905e
to
cd4f27f
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-grid-tile
branch
2 times, most recently
from
November 13, 2024 00:05
212ab5a
to
0befc5b
Compare
matthewhartstonge
changed the title
feat(addon/components): converts paper-grid to glimmer components.
feat(addon/components/paper-grid): converts to glimmer components.
Nov 13, 2024
matthewhartstonge
force-pushed
the
feature/glimmer-paper-grid-tile
branch
from
November 13, 2024 12:54
0befc5b
to
f8fb64e
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-button
branch
from
November 14, 2024 01:09
c74a886
to
bfd8cc0
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-grid-tile
branch
from
November 14, 2024 01:10
f8fb64e
to
bfa6a27
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-button
branch
from
November 14, 2024 02:55
bfd8cc0
to
1515e49
Compare
matthewhartstonge
force-pushed
the
feature/glimmer-paper-grid-tile
branch
2 times, most recently
from
November 15, 2024 02:46
0837a8c
to
8dea1ea
Compare
mansona
force-pushed
the
feature/glimmer-paper-button
branch
from
November 15, 2024 15:14
66a32f0
to
b7c63d1
Compare
…on child de/registration.
… a computed property (getter).
…run loop to request animation frame.
… pattern when children need to update.
…g on DOM mutations.
…tect DOM elements being reordered.
matthewhartstonge
force-pushed
the
feature/glimmer-paper-grid-tile
branch
from
November 17, 2024 22:20
8dea1ea
to
05d7c66
Compare
Some tests with 'continue-on-error: true' have failed:
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Instead of using ember runloop, this does rely on
requestAnimationFrame
for debouncing. (breaking change?)Builds on #1298