Update ember-cli to 5.8.1 and add ember-data peer dependencies #190
+5,435
−5,784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My apologies, I am no longer involved with this project. Perhaps @mfeckie can assist. |
|
I don't have commit permissions for this project either |
do you have any idea who does? |
|
@MelSumner @Alonski @knownasilya can someone merge this PR please? |
|
looks like there are now a bunch of typescript errors.. I'd appreciate any help resolving those |
knownasilya
requested changes
Jul 9, 2024
README.md
Outdated
| @@ -23,7 +23,7 @@ into your serializer: | |||
| ```javascript | |||
| // app/serializers/post.js | |||
|
|
|||
| import { ActiveModelSerializer } from 'active-model-adapter'; | |||
| import { ActiveModelSerializer } from "active-model-adapter"; | |||
There was a problem hiding this comment.
I'd keep these single quote, since that's also the rule for the prettier config of this codebase and for new ember apps.
There was a problem hiding this comment.
good spot, for some reason prettier was changing them to double quotes and I hadn't noticed
|
@lozjackson looks like some type lint errors? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ember-cli to 5.8.1 and adds
@ember-data/adapterand@ember-data/serializertopeerDependenciesto make this library compatible with ember-data 5.3.8Fixes #189