Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with ember-data 5.3.8: Could not find module @ember-data/adapter/rest #189

Open
lozjackson opened this issue Jul 1, 2024 · 1 comment · May be fixed by #190
Open

Error with ember-data 5.3.8: Could not find module @ember-data/adapter/rest #189

lozjackson opened this issue Jul 1, 2024 · 1 comment · May be fixed by #190

Comments

@lozjackson
Copy link

lozjackson commented Jul 1, 2024 •
edited
Loading

Since upgrading ember-data I'm getting an error in the console

Error: Could not find module @ember-data/adapter/rest imported from active-model-adapter/active-model-adapter

I guess something changed with ember-data in that version.

I'm not sure where the problem is (this project, or ember-data) - I've created an issue in the ember-data repo here emberjs/data#9504
@lozjackson lozjackson mentioned this issue Jul 1, 2024
Closed
@runspired
Copy link
Contributor

This is happening because this library does not properly declare either a dependency or a peerDependency on ember-data or @ember-data/adapter

Adding the proper dependency to package.json should be enough to fix even without converting this library to be a v2 addon.

@lozjackson lozjackson linked a pull request Jul 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ember-cli to 5.8.1 and add ember-data peer dependencies lozjackson/active-model-adapter
2 participants
@runspired @lozjackson