Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-15835 - httpclient-osgi dependency change #2585

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

edoardo-goracci
Copy link
Contributor

Q                       A
Fixed Issues? Fixes SITES-15835
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? No
Documentation Provided No (code comments and or markdown)
Any Dependency Changes? org.apache.httpcomponents:httpclient-osgi:4.5.13 changed to com.day.commons.osgi.wrapper:com.day.commons.osgi.wrapper.commons-httpclient:3.1.0.018
License Apache License, Version 2.0

Changed httpclient-osgi dependency to com.day.commons.osgi.wrapper.commons-httpclient and added a target folder exclusion to apache-rat-plugin configuration

…gi.wrapper.commons-httpclient and addition to apache-rat-plugin exclusions
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2585 (9209784) into main (e8fc23a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2585   +/-   ##
=========================================
  Coverage     87.33%   87.33%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7076     7076           
  Branches       1073     1073           
=========================================
  Hits           6180     6180           
  Misses          359      359           
  Partials        537      537           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edoardo-goracci edoardo-goracci merged commit 58194f1 into main Sep 14, 2023
15 checks passed
@edoardo-goracci edoardo-goracci deleted the issue/SITES-15835 branch September 14, 2023 07:18
@vladbailescu vladbailescu added this to the 2.23.4 milestone Sep 14, 2023
@LSantha LSantha changed the title SITES-15835 -httpclient-osgi dependency change SITES-15835 - httpclient-osgi dependency change Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants