Close the socket when there is an error using the socket #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two related problems which made reconnecting not work after the connection to the server gets dropped unexpectedly. The MQTT client continues sending messages and on ESP32 eventually an OSError is raised. The client must then reconnect. But reconnect was failing because the Adafruit Connection Manager was returning the same broken socket for the server since it hadn't yet been closed by MiniMQTT. Explicitly calling disconnect() would also not close the socket because it tries to send the disconnect packet on the broken socket which raised an OSError preventing the socket from being closed.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 15, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.10.4 from 7.10.3: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#224 from rbedia/socket-handling Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two related problems which made reconnecting not work after
the connection to the server gets dropped unexpectedly.
The MQTT client continues sending messages and on ESP32 eventually an
OSError is raised. The client must then reconnect. But reconnect was
failing because the Adafruit Connection Manager was returning the same
broken socket for the server since it hadn't yet been closed by
MiniMQTT.
Explicitly calling disconnect() would also not close the socket because
it tries to send the disconnect packet on the broken socket which raised
an OSError preventing the socket from being closed.