-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Displayio and Add grayscale #114
Conversation
Feel free to add me as reviewer when it is ready. Thanks for doing this! |
If I had to guess, I'd say it's a row and column offset issue at this point. |
I'm going to fix the SSD1306 and I think the PR will be ready at that point. The other possibility is that it's throwing some garbage to the display prior to writing as the right side of the rectangle does wrap to the left side. |
@FoamyGuy I added you as a reviewer since this change will likely affect https://github.com/FoamyGuy/Blinka_Displayio_PyGameDisplay since some of the "protected" functions have been renamed to match the ones used in the core. The plan is to release this as 1.0.0 after this PR is merged, so it will be a new major version anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! Didn't see anything that needs updating. Thank you so much for doing this porting.
You're welcome. I think I found one more bug that needs fixing first. |
This change brings Displayio to being much closer in line with the current circuitpython builds, which makes it very accurate, but at this point it is not optimized for running in Python due to some removal of PIL. This adds dirty rectangle tracking as well. I have a bit more testing to do before optimization but it should support monochrome and grayscale OLEDs and allow me to close a number of outstanding issues.
Fixes #105
Fixes #95
Fixes #94
Fixes #54
Fixes #36
Fixes #32
Fixes #7
Fixes #6
Fixes #4