Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Raya 1-5 files #10
base: master
Are you sure you want to change the base?
Add Raya 1-5 files #10
Changes from 1 commit
6e1e13c
f5083ef
7a83ceb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using a scale of 17 for this type of puzzle; I'd suggest we standardize on that for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for going with 0.16 mm inset rather than 0.125 (as in other packing puzzles)? Was the smaller inset too tight on your prints?
(I'm not necessarily objecting to a larger inset, but we should be consistent... i.e. use the same value here as in Mushkila and the other packing puzzles, unless there's a good reason they should be different)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Aaron, on my printer 0.125 seems to be too tight for packing puzzles but I agree it should be standard. I will adjust to standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm. I have gotten reports from other users that default tolerances are too tight.. it seems there is a lot of variation in tolerances by printer. I am thinking it might make sense to distribute two versions of every puzzle with different tolerances (as different STLs, built from the same .scad)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This nomenclature seems a little confusing (there are two sets of dimensions defined with similar names). My suggestion is to declare like so:
interior_dim = [4, 3, 2] * box_puzzle_scale;
Then you can use interior_dim.x, interior_dim.y, and interior_dim.z to refer to the individual coordinate dimensions, if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you follow my suggestion above, this can become
dim = interior_dim + [box_puzzle_border * 2, box_puzzle_border * 2, box_puzzle_border];
Then dim.x, dim.y, dim.z will refer to the outer dimensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I did not know dimensions could be done as vectors. This is much better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a * in front of it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code style: add a space after the commas (also applies below)