Create scan_for_joycons()
#14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yamakaky
reviewed
Mar 14, 2022
Yamakaky
reviewed
Mar 14, 2022
The goal of this change is to take boilerplate code (code that has to appear in every program that uses the joycon crate) and move it into the library itself.
Jayman2000
force-pushed
the
scan-for-joy-cons
branch
from
49252d1
to
81567bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make it easier to create new
JoyCons.Here’s some things that I was unsure about:
scan.rsfile. I’m not very familiar with how this project is organized, so I don’t really know if that’s a good place to put it.DetectedJoyConInfo::connectto return aResult, but I had two error types instead of one. I createdConnectionErrorto solve this problem, but I’m not sure if that’s the best solution.