Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent build step in modules from running in parallel #3053

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Nov 13, 2024

Summary

ts-patch was running our typescript builds in parallel, causing cache issues between modules. Removing --parallel from the build step within each package so that it is sequential.

Release Category

Infrastructure


Copy link

cypress bot commented Nov 13, 2024

Workday/canvas-kit    Run #8047

Run Properties:  status check passed Passed #8047  •  git commit 44d4aa3090 ℹ️: Merge 143bd0aec7fb3f3da939fa533397f266f826f647 into 648318a5b6f4c8d65217d7933f7d...
Project Workday/canvas-kit
Branch Review mc-cli-tspc
Run status status check passed Passed #8047
Run duration 04m 00s
Commit git commit 44d4aa3090 ℹ️: Merge 143bd0aec7fb3f3da939fa533397f266f826f647 into 648318a5b6f4c8d65217d7933f7d...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 30
Tests that did not run due to a developer annotating a test with .skip  Pending 24
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1093
View all changes introduced in this branch ↗︎
UI Coverage  21.76%
  Untested elements 1641  
  Tested elements 454  
Accessibility  99.18%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 181  

@mannycarrera4 mannycarrera4 reopened this Nov 13, 2024
@mannycarrera4 mannycarrera4 marked this pull request as ready for review November 13, 2024 22:58
@mannycarrera4 mannycarrera4 changed the title fix: Prevent build from running in parallel fix: Prevent build step in modules from running in parallel Nov 13, 2024
@alanbsmith alanbsmith merged commit 66d1c56 into Workday:master Nov 13, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants