Make it easier to add additional mount options #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `default` attribute of `mkOption`, the default value is assigned with a very low priority and is overwritten by any other assignment to the same option. For the mount options, this will rarely be the desired behaviour, and users will need to remember to add the default mount options themselves when setting any additional mount options. In this case, I think it's better to assign the default value with the normal priority so that any additional assignments are simply added. If a user really wants to overwrite the default options, they can use `mkForce`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
defaultattribute ofmkOption, the default value is assigned with a very low priority and is overwritten by any other assignment to the same option.For the mount options, this will rarely be the desired behaviour, and users will need to remember to add the default mount options themselves when setting any additional mount options.
In this case, I think it's better to assign the default value with the normal priority so that any additional assignments are simply added.
If a user really wants to overwrite the default options, they can use
mkForce.