[2.38] Taking some IOS GC branches for WPE as well #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magomez
requested changes
Oct 22, 2024
| @@ -40,7 +40,7 @@ namespace WTF { | |||
|
|
|||
| WTF_EXPORT_PRIVATE bool MemoryPressureHandler::ReliefLogger::s_loggingEnabled = false; | |||
|
|
|||
| #if PLATFORM(IOS_FAMILY) | |||
| #if PLATFORM(IOS_FAMILY) || PLATFORM(WPE) | |||
There was a problem hiding this comment.
We cannot change the default values of the fractions, cause this affects all of the devices. As I told you in previous PRs, there's API to change these values for your platform only, please use it.
The aim is to make the GC more reliable on low-memory platforms. In FullGCActivityCallback, the change is to do not bail out of GC early.
The aim is to make the GC more reliable on low-memory platforms. In MemoryRelease, the change is to request immediate GC in releaseCriticalMemory.
The aim is to make the GC more reliable on low-memory platforms. In WorkerGlobalScope::deleteJSCodeAndGC the change is to collect even if called with 'Synchronous::No'
tomasz-karczewski-red
force-pushed
the
RDK-588_GC_finetuning_use_IOS_branches
branch
from
7cd0bde
to
8c1c5e5
Compare
|
sure - I've just updated the PR |
magomez
approved these changes
Oct 22, 2024
|
@modeveci , this is technically fine for merge, but it's adding changes to how the memory release is done and may have an impact in performance, so it should be verified on your side first. |
|
Thanks @magomez, we'll investigate if there are any performance issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to make the GC more reliable on low-memory platforms. IOS branches applied: