[WIP] [DO NOT MERGE] improved integration tests a little bit #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
requested changes
Jul 22, 2024
.github/workflows/ci.yml
Outdated
| @@ -61,8 +61,6 @@ jobs: | |||
| env: | |||
| PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }} | |||
| PGP_SECRET: ${{ secrets.PGP_SECRET }} | |||
| SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | |||
There was a problem hiding this comment.
This should stay, otherwise not password and username would be available. The release should be fixed, it seems org secrets were not set for this repo, which is why it didn't see the change
… yaml differently, added passing ScalarStyle to nodes so that we render nodes as they were, unborked 6H3V this way, this is like constant cramp in my gray matter, yaml is horrible
lbialy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.