Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commas being treated as using directives value separators & deprecate using them with whitespace #3333

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fix commas being treated as using directives value separators & deprecate using them with whitespace #3333

wants to merge 8 commits into from

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Nov 28, 2024 •
edited
Loading

Fixes #3282

The fix itself is contained in the using_directives bump to 1.1.2:

Specifically, it's this change:

What this PR does:

  • bumps using_directives to 1.1.2
  • adds tests ensuring the old syntax is no older honored (no longer can use commas on their own as value separators)
  • adds tests for the deprecation of using commas with whitespace as value separators
  • updates the syntax in docs, old code & tests (which contributes the most to the change line count)

@Gedochao Gedochao force-pushed the update/using_directives-1.1.2 branch 2 times, most recently from 49f3bec to 0fa4c34 Compare November 29, 2024 11:56
@Gedochao Gedochao force-pushed the update/using_directives-1.1.2 branch from 0fa4c34 to 1ae6722 Compare November 29, 2024 13:53
@Gedochao Gedochao mentioned this pull request Dec 2, 2024
Closed
@Gedochao
NIT refactor using directives usage in directives, options & docs
2145011 
- get rid of unnecessary commas and double quote escapes
- bump versions where applicable
- misc typo fixes & tweaks
@Gedochao
NIT refactor using directives usage in gifs: get rid of unnecessary c…
69be9c0 
…ommas and double quote escapes
@Gedochao
NIT refactor using directives usage in publish setup-generated code…
a719003 
…: get rid of unnecessary commas and double quote escapes
@Gedochao
NIT refactor using directives usage in gcbenchmark: get rid of unne…
9d7f532 
…cessary commas and double quote escapes
@Gedochao
NIT refactor using directives usage in integration tests: get rid of …
46e6a9c 
…unnecessary commas and double quote escapes
@Gedochao
NIT refactor using directives usage in unit tests: get rid of unneces…
1595b20 
…sary commas and double quote escapes
@Gedochao Gedochao force-pushed the update/using_directives-1.1.2 branch from 358244a to 1595b20 Compare December 2, 2024 14:18
@Gedochao Gedochao changed the title Update using_directives to 1.1.2 Fix commas being treated as using directives value separators & deprecate using them with whitespace Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commas shouldn't be interpreted as directive value separators on their own
1 participant
@Gedochao