-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier (from #59) #76
base: v2-mst-aptd-gcms-lcz-sty
Are you sure you want to change the base?
Conversation
[GitHub Actions] |
[GitHub Actions] |
[GitHub Actions] |
@samuelcastro I've made some more attempts and wasted a few more hours on this. Overall, Prettier makes code look worse than before, their non-configurable opinionated choices aren't for me. Do you know of any alternative? Couldn't eslint do some of it, maybe? |
[GitHub Actions] |
https://www.reddit.com/r/javascript/comments/8as6ns/i_dont_like_prettier/
🤣 |
https://github.com/prettier/prettier-eslint may likely be the best alternative, it's basically a customisable prettier through eslint rules. |
[GitHub Actions] |
[GitHub Actions] |
…quite a lot, but no way to override prettier's opinions (e.g array-element-newline)
[GitHub Actions] |
[GitHub Actions] |
I don't have any other alternative, we could stick with just eslint for now. |
I've tried a lot with prettier, and I'm not satisfied with the job it does. While it surely helps on some part of the code, it also makes other parts less readable/maintainable. We'll stick to eslint for now, I hope it evolves in the right direction, or a proper alternative is made available. |
1dcbd4d
to
9da75b0
Compare
[GitHub Actions] |
FYI I'm following https://github.com/romefrontend/rome new features and hope it'll eventually be able to replace Prettier/EsLint. |
WIP
Waiting on prettier/prettier#6644 to be merged
Big discussion on prettier/prettier#8507 about Prettier's mindset and goals
See: