Cleanup flow sensor detection margin in material profiles #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…profiles and rely on the machine json defaults. The defaults settings for S-line machines is 0.8 and for F4 it is 0.5 (see default_flow_sensor_detection_margin in the machine json files in opinicus). For very flexible materials we reduced the detect margin to 0.2 for F4 machines to trigger earlier. This prevents material buckling. PP-467
wawanbreton
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "flow sensor detection margin" settings from the material profiles and rely on the machine json defaults. The defaults settings for S-line machines is 0.8 and for Factor 4 it is 0.5 (see default_flow_sensor_detection_margin in the machine json files in opinicus). For very flexible materials we reduced the detect margin to 0.2 for F4 machines to trigger earlier. This prevents material buckling.
PP-467