Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-10831 #274

Merged
merged 13 commits into from
Dec 8, 2023
Merged

CURA-10831 #274

merged 13 commits into from
Dec 8, 2023

Conversation

jellespijker
Copy link
Member

@jellespijker jellespijker commented Dec 6, 2023

Description

Ported a lot of workflow to use the reusable workflows in the new Cura-workflows repository. See PR: Ultimaker/cura-workflows#1

The biggest impact on this repository is that the version of the conan package is now determined by the version key in conandata.yml and no longer determined based on the git tag. During a push the Conan user, channel is determined based Github runner context, see the conan-recipe-versions.yml in the Cura-workflows and the semver build metadata is added from the sha of the reference name (git hash).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Locally
  • Remote

Test Configuration:

  • Operating System: Linux, Windows, Mac

Checklist:

This will allow workflow automations to easily create release branches and set the versions

Contributes to CURA-10831
Added an `export` method in conanfile.py to update the conandata with the current version. Minor modifications were also made to the GitHub workflow, removing redundant job steps and reformatting it for clarity. Version exports are now also disabled in the 'conan-package-export-linux' job.

Contributes to CURA-10831
@jellespijker jellespijker mentioned this pull request Dec 6, 2023
10 tasks
casperlamboo
casperlamboo previously approved these changes Dec 8, 2023
.github/workflows/conan-package.yml Outdated Show resolved Hide resolved
.github/workflows/conan-package.yml Outdated Show resolved Hide resolved
.github/workflows/conan-package.yml Outdated Show resolved Hide resolved
.github/workflows/process-pull-request.yml Outdated Show resolved Hide resolved
.github/workflows/process-pull-request.yml Outdated Show resolved Hide resolved
@jellespijker jellespijker merged commit ae870b6 into master Dec 8, 2023
5 checks passed
@jellespijker jellespijker deleted the CURA-10831 branch December 8, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants