Feature/export experiments #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krebsni
commented
May 27, 2022
•
krebsni
commented
- refactor export/import experiments into long-running tasks
- add filter for experiment export
…ved to types in the future)
…ved to types in the future)
…ipping not implmented yet
2 tasks
…er... seems to be bug in ballerina
buehlefs
requested changes
Nov 2, 2022
buehlefs
requested changes
Nov 21, 2022
modules/database/export.bal
Outdated
| # | ||
| # + test - some config field | ||
| public type ExperimentExportConfig record {| | ||
| string test; // TODO |
There was a problem hiding this comment.
for a future PR export config needs to be added
There was a problem hiding this comment.
Then clarify the TODO comment (just TODO is not enough...)
modules/database/export.bal
Outdated
| result = check os:exec({value: "powershell", arguments: ["Compress-Archive", "-Update", jsonPath, zipPath]}); | ||
| } else { | ||
| return error("Unsupported operating system! At the moment, we support 'linux' and 'windows' for importing/exporting experiments. Please make sure to properly specify the os env var or config entry."); | ||
| if !os.toLowerAscii().includes("linux") { |
There was a problem hiding this comment.
see comment above, also check if else needs {} if it is meant as else-if.
There was a problem hiding this comment.
in case it's not linux but linux-like it may be worth printing an error and still trying to run the exec. If it fails an exception should be raised. Therefore the if within the else.
buehlefs
requested changes
Nov 25, 2022
buehlefs
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.